feat: 'make multi' to build and push multiarch docker image with arm64,amd64,arm archs#16
Open
muravjov wants to merge 1 commit intobrancz:masterfrom
Open
feat: 'make multi' to build and push multiarch docker image with arm64,amd64,arm archs#16muravjov wants to merge 1 commit intobrancz:masterfrom
muravjov wants to merge 1 commit intobrancz:masterfrom
Conversation
…4,amd64,arm archs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your work.
I use arm64 based k8s and following the tutorial at https://prometheus-operator.dev/docs/developer/getting-started/#deploying-a-sample-application
I got an issue that the image in question cannot be run on my node because:
This patch intoduces a new Makefile
multiwhich builds and pushes a multiarch image to quay.io/brancz/prometheus-example-app:v0.5.0 .If you want to test it locally without pushing, run
make multiwith this patch:$ git diff diff --git a/Makefile b/Makefile index e2970a9..a2ecd85 100644 --- a/Makefile +++ b/Makefile @@ -9,4 +9,4 @@ all: build docker build -t quay.io/brancz/prometheus-example-app:$(VERSION) . multi: build - docker buildx build --push --platform linux/arm/v7,linux/arm64/v8,linux/amd64 -t quay.io/brancz/prometheus-example-app:$(VERSION) . + docker buildx build --platform linux/arm/v7,linux/arm64/v8,linux/amd64 -t quay.io/brancz/prometheus-example-app:$(VERSION) .