This repository was archived by the owner on Aug 19, 2021. It is now read-only.
Open
Conversation
added 4 commits
November 6, 2020 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix to filter 86 - filter on deleted cf stacks
fix to issue 101 - Crystal add_time_ms.patch - "patch does not apply"… …
fix issue in failures/updatecrystal/ patch - "patch does not apply" e… …
Fix issue - Envoy v1.15.1.0-prod is not sending correct traces to X-Ray
Description of changes:
I fix 4 issues: 2 of them where raised in the repo.
One of the other issues was similar to 101 but in a different module of the workshop.
I also modified an issue related to envoy v1.15.1.0 and x-ray traces. I add it an older version of envoy that works.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.