test:add cython synapses regression coverage for #1769#1805
test:add cython synapses regression coverage for #1769#1805mushkanrana73 wants to merge 2 commits intobrian-team:masterfrom
Conversation
|
Hi! I investigated this issue locally and opened a small regression-test PR for it. What I verified:
PR: [https://github.com//pull/1805] If useful, I can also extend coverage further depending on the exact failure scenario expected for #1769. |
|
Fixed the failing regression test by removing the direct test call at the bottom of |
|
Hi @mushkanrana73, thanks for the PR. I'm a bit confused about what regression it tests for. The "issue #1769" is not an issue but a PR, and I don't see how it relates to this? I think everything that the test does is already covered by other tests. Also note:
|
|
Hi @mstimberg, thank you for the detailed feedback! I realize now that I misunderstood #1769 as an issue rather than a PR, and my test does not target a specific regression. It also seems to overlap with existing test coverage. I’ll review the current tests more carefully and either refine this to cover a genuinely missing case or remove it if it is redundant. I’ll also fix the formatting using pre-commit and update the test to follow the recommended practices. Thanks again for the guidance! |
Summary
This PR adds a regression test for issue #1769 by verifying that a simple
Synapsesexample runs correctly with the Cython code generation target.What this tests
prefs.codegen.target = "cython"NeuronGroup+Synapsessetupon_presynaptic updateWhy
Issue #1769 involves the Cython execution/codegen path for synapses.
This test helps ensure that the relevant synaptic execution path continues to work correctly and can catch future regressions.
Validation
Tested locally with:
Also manually validated with a minimal Brian2 script using: