Skip to content

use a different method to obtain the HTTP status code in the JsonRpcRestClient #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyb3r4nt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use a different method to obtain the HTTP status code in the JsonRpcRestClient #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/main/java/com/googlecode/jsonrpc4j/spring/rest/JsonRpcRestClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,14 +216,15 @@ public Object invoke(String methodName, Object argument, Type returnType, Map<St
try {
response = this.restTemplate.postForObject(serviceUrl.get().toExternalForm(), requestHttpEntity, ObjectNode.class);
} catch (HttpStatusCodeException httpStatusCodeException) {
logger.error("HTTP Error code={} status={}\nresponse={}"
, httpStatusCodeException.getStatusCode().value()
, httpStatusCodeException.getStatusText()
, httpStatusCodeException.getResponseBodyAsString()
int statusCode = httpStatusCodeException.getRawStatusCode();
logger.error("HTTP Error code={} status={}\nresponse={}",
statusCode,
httpStatusCodeException.getStatusText(),
httpStatusCodeException.getResponseBodyAsString()
);
Integer jsonErrorCode = DefaultHttpStatusCodeProvider.INSTANCE.getJsonRpcCode(httpStatusCodeException.getStatusCode().value());
Integer jsonErrorCode = DefaultHttpStatusCodeProvider.INSTANCE.getJsonRpcCode(statusCode);
if (jsonErrorCode == null) {
jsonErrorCode = httpStatusCodeException.getStatusCode().value();
jsonErrorCode = statusCode;
}
throw new JsonRpcClientException(jsonErrorCode, httpStatusCodeException.getStatusText(), null);
} catch (HttpMessageConversionException httpMessageConversionException) {
Expand Down
Loading