Conversation
- Updated @aws-sdk/client-dynamodb and @aws-sdk/lib-dynamodb to latest - Added override for fast-xml-parser@5.3.4 to fix high severity vulnerability Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
BREAKING CHANGES: - Package now uses ES modules (import/export) - Requires Node.js 18+ - Updated numberstring to v1.0.0 (from GitHub until npm publish) Changes: - Converted all require() to import statements - Updated module.exports to export default - Added "type": "module" to package.json - Updated Jest config for ESM support - Bumped version to 1.0.0 - Fixed npm audit vulnerabilities with fast-xml-parser override Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc63faac43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "node_modules/numberstring": { | ||
| "version": "1.0.0", | ||
| "resolved": "git+ssh://git@github.com/brianfunk/numberstring.git#c5db19ee4609a1ccbfa8700839a0f2c4762253c5", |
There was a problem hiding this comment.
The lockfile now pins numberstring to a git+ssh:// URL, which makes npm install require GitHub SSH credentials. In CI or user environments without an SSH key, install fails even though the repo is public. If you want a GitHub dependency, prefer an HTTPS resolved URL in the lockfile or publish to npm so installs succeed without SSH access.
Useful? React with 👍 / 👎.
| "engines": { | ||
| "node": ">=18.0.0" | ||
| "node": ">=20.0.0" | ||
| } |
There was a problem hiding this comment.
The updated @aws-sdk/client-dynamodb package now declares node >=20. If your runtime is still Node 18 (as previously documented), installs will at least warn (or fail under engine-strict) and the SDK is outside its supported runtime. This effectively raises the minimum Node version, so either pin an SDK version that supports 18 or update the runtime requirements accordingly.
Useful? React with 👍 / 👎.
- Add engines field requiring Node >=20.0.0 (AWS SDK v3.980+ requires it) - Use explicit git+https URL for numberstring dependency - Regenerate package-lock.json Note: npm still resolves to git+ssh internally, but GitHub Actions handles this correctly. Once numberstring is published to npm, update dependency to use npm package instead. Addresses Codex review feedback on PR #19. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Both Codex suggestions addressed in commit
Thanks @codex for the helpful review! |
|
To use Codex here, create an environment for this repo. |
- Replace Heroku badge with generic shields.io badge - Update Node.js prerequisite to 20+ (AWS SDK requirement) - Update Dockerfile example to use node:20-alpine Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 participant
Summary
Breaking Changes
import/export)Test plan
🤖 Generated with Claude Code