issue-38: Support ArrayAccess objects in pluck#39
Open
Tohnmeister wants to merge 2 commits intobrianhaveri:masterfrom
Tohnmeister:feature/issue-38
Open
issue-38: Support ArrayAccess objects in pluck#39Tohnmeister wants to merge 2 commits intobrianhaveri:masterfrom Tohnmeister:feature/issue-38
Tohnmeister wants to merge 2 commits intobrianhaveri:masterfrom
Tohnmeister:feature/issue-38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although I understand that objects of type ArrayAccess don't and shouldn't behave the same way as arrays, it would be great if pluck would support objects of type ArrayAccess just like any other arrays or objects.
This commit supports that behavior and contains the additional unit tests for that.