[WIP] Sqm enhancements #374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c872394.
Move saturation handling from auto-exposure to SQM calculation: - SQM: detect saturated stars (max aperture pixel >= 250) and exclude from mzero calculation by setting flux to -1 - Auto-exposure: remove saturation detection, just target background level This allows longer exposures for better background SNR while ignoring bright saturated stars that would corrupt the photometric calibration. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
colors.get() only takes intensity, not red=True keyword argument. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
SQM state only has value, source, last_update - not value_raw. Store source in metadata instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change target_background from min*1.25 to min+2 for more linear camera response and less saturation risk. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add noise_floor to shared state (solver writes, camera reads) - SNR controller uses adaptive noise floor + 2 as min_background - Falls back to static camera profile if noise floor not yet available This gives more accurate exposure control based on real-time noise measurements instead of static camera profile values. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Show 'Saving...' message immediately before creating zip - Remove +2 margin from noise floor - target exact value for shortest exposure Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Includes: mzero, mzero_std, background, pedestal, extinction, star counts, saturation info, etc. - everything needed for calibration validation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Captures 3 exposures: base, +1 stop, -1 stop (or base, -1, -2 if at max). Shows progress for each bracket. Re-enables auto-exposure when done. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Faster sweep (~1 min vs ~4 min) while still sampling exposure space. Launch from SQM view → hold square → DEBUG. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Brighter stars have higher SNR so their mzero estimates are more reliable. Weight each star's contribution by its flux. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Without margin, background_corrected ≈ 0 when at noise floor, causing log10(~0) = very negative, making SQM too high. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…tion Two fixes for SQM being ~0.4 mag too high: 1. Use only bias_offset (6.0 ADU) as pedestal instead of full noise_floor (7.46 ADU). Read noise and dark current are random fluctuations, not systematic offsets that should be subtracted. 2. Disable atmospheric extinction correction. When comparing to ground-based SQM meters, both measurements are through the same atmosphere, so no correction is needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use 0.1 mag/airmass to match typical consumer SQM meters instead of the scientific V-band value (0.28). This enables comparing measurements at different altitudes while staying consistent with reference meters. At zenith: +0.10 mag At 45°: +0.14 mag At 30°: +0.20 mag Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ased for science
- Main SQM value uses fixed 0.1 mag extinction (matches consumer SQM meters)
- Also calculate altitude-dependent extinction (0.1 mag/airmass)
- Display altitude-corrected value on SQM view in small font ("alt: XX.XX")
- Enables comparing measurements at different altitudes scientifically
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Main SQM value: raw measurement (no extinction correction) - Altitude-corrected: adds 0.28*(airmass-1) per ASTAP convention - Zenith is reference point (extinction=0), only additional extinction below zenith is added for altitude comparison At different altitudes: - Zenith (90°): extinction = 0 - 45°: extinction = 0.115 - 30°: extinction = 0.28 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Simplify SQMCalculator API by removing unused parameters - Add robust Cedar-to-tetra3 fallback when centroid extraction fails - Fix read noise calculation to use temporal variance (avoids PRNU) - Add calibration indicator (CAL/!CAL) to SQM display - Expand test coverage for SQM functionality Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix PID integral crash: Reset integral when error changes sign (prevents -487,500µs crash when going from too many → too few stars) - Start sweep at 400ms instead of 25ms for faster recovery - Add sleep mode logging to diagnose camera blocking issues - Revert default to PID (SNR exposures too long on clear nights) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests now reflect the new sweep pattern that starts at 400ms instead of 25ms for faster recovery. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Move inline imports to file tops per project convention: - camera_profiles.py: numpy import - test_sqm.py: NoiseFloorEstimator import - Add unit tests for previously untested functions: - SQM._measure_star_flux_with_local_background() - get_camera_profile(), detect_camera_type() - CameraProfile.crop_and_rotate() - save_sweep_metadata() - Add Pickering airmass test for 5° altitude - Improve __init__.py docstrings - Document centroid (row, col) convention in docstrings Test coverage: 37 → 65 tests, ~92% coverage Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- SQM now uses bias_offset directly from camera profile (no NoiseFloorEstimator at runtime)
- Load calibration from ~/PiFinder_data/sqm_calibration_{camera_type}.json on init
- Add indoor calibration mode: skip sky frames in calibration wizard (press 0)
- Combine exp_sweep and sqm_correction into single sqm_sweep tool
- Add full NoiseFloorEstimator output to sweep/correction metadata
- Add read_noise, dark_current to SQM details for diagnostics
- Menu: CAL (indoor calibration), CORRECT (sweep with full metadata)
- Fix bias_offset comment: measured from bias frames, not tuned to SQM-L
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Simplify the PID controller by removing: - Rate limiting (update_interval, _last_adjustment_time) - Asymmetric gains (gains_decrease/gains_increase → single gains tuple) - Unused time import The PID now responds immediately to all errors with uniform gains. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MarkingMenu dataclass requires down, left, and right arguments. Added empty right option to fix TypeError on SQM screen launch. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change "Hold steady..." to "Keep cap on..." during bias and dark frame captures, since the telescope cap should be on during these steps. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifications:
Fixes:
Tests: