Open
Conversation
Contributor
Author
|
@kylewlacy I didn't broadly set |
0bcdce7 to
eb9085a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update the default behaviour on Git checkout when using
gitCheckoutfromgitrecipe orBrioche.gitCheckout. As of today, the.gitfolder is always present after a checkout, but most of the time, we don't need this folder to be present for the recipe's source. Some recipes do need it to retrieve their version, but that's not the majority.One of the consequence to have
.gitfolder present in the source is it introduces some variances in the filesystem. On multiple git checkouts from the same remote, the output's hash will be each time different..gitfolder is not designed to be fixed, it embeds some metadata such as timestamps, which prevent its reproducibility even on a shallow clone.One direct impact of this source hash variance is each time we update
gitrecipe or one of its dependencies, Brioche rebuilds all the recipes relying ongitCheckoutwhich can take multiple hours. With this PR, we will remove one source of variance in the recipe's source, and hopefully reduce the build time of the CI.A new option has been introduced
keepGitDirto keep the.gitfolder when the recipes need it.