refactor: remove the crate bstr from the dependency#102
Conversation
116d676 to
a594261
Compare
|
I think it'll take some research on my part before I'm ready to merge this 😅 I looked at the docs for both |
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
a594261 to
d8533f3
Compare
kylewlacy
left a comment
There was a problem hiding this comment.
LGTM
I'm honestly still not sure about how bstr's from_bytes vs. the std library's works, and I don't really feel that strongly about keeping / removing bstr honestly (it's a nice convenience but not for how we're using it here).
I'm good to get rid of it though. It seems pretty low-risk overall, given how slowly this repo evolves and how it really gets put through its paces when brioche-packages updates it
@jaudiger let me know if you want me to take over resolving conflicts or anything here
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
|
Thanks @kylewlacy, I manually resolved the merge conflicts, and set auto-merge. |


This PR simplifies a bit the
brioche-runtime-utilscodebase by removing the cratebstrto instead rely exclusively on methods fromstd. The main advantage to use the methods from the standard is there are infaillible which removes a bunch of indirection in the code that were related to error handling (which explains the removal of 100 lines).We still need
bstrbut it's now a transitive dependency.