Skip to content

fix(autopack): ensure shared library with interpret section is detected as AutopackKind::SharedLibrary #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaudiger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(autopack): ensure shared library with interpret section is detected as AutopackKind::SharedLibrary #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/brioche-autopack/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,13 +439,16 @@ fn autopack_kind(path: &Path) -> eyre::Result<Option<AutopackKind>> {
return Ok(None);
};

// Only ET_EXEC and ET_DYN can potentially be packed
// Only ET_EXEC and ET_DYN can potentially be packed.
// Check if it's a library first. A shared library can
// have an interpreter section and it should be packed
// as SharedLibrary, not DynamicBinary.
match elf_object.header.e_type {
goblin::elf::header::ET_EXEC | goblin::elf::header::ET_DYN => {
if elf_object.interpreter.is_some() {
Ok(Some(AutopackKind::DynamicBinary))
} else if elf_object.is_lib {
if elf_object.is_lib {
Ok(Some(AutopackKind::SharedLibrary))
} else if elf_object.interpreter.is_some() {
Ok(Some(AutopackKind::DynamicBinary))
} else {
Ok(None)
}
Expand Down