Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

put disk access into background thread? #12

Open
yulin2 wants to merge 9 commits into
base: master
Choose a base branch
from
Open

put disk access into background thread? #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f7b94ba
Update PhotoViewerActivity.java
yulin2 Oct 19, 2014
94227f6
rename params
yulin2 Oct 19, 2014
231358b
Update PhotoViewerFragment.java
yulin2 Oct 19, 2014
1d80b47
Update PhotoUploadActivity.java
yulin2 Oct 19, 2014
abc20ab
add final keywords
yulin2 Oct 19, 2014
b3663e8
Update LocalPhotosGridFragment.java
yulin2 Oct 19, 2014
255334e
remove async refactoring that lead to races
yulin2 Dec 3, 2014
04a25a6
import Bitmap
yulin2 Dec 3, 2014
ecedb6d
add final keyword to thumbPath
yulin2 Dec 3, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions app/src/main/java/com/bourke/glimmr/activities/PhotoUploadActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
import com.bourke.glimmr.BuildConfig;
import android.content.Context;
import android.content.Intent;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.os.AsyncTask;
import android.os.Bundle;
import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentManager;
Expand Down Expand Up @@ -186,14 +188,24 @@ public static ImageFragment newInstance(String imageUri) {
public View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) {

ImageView image = new ImageView(getActivity());
final ImageView image = new ImageView(getActivity());
LinearLayout.LayoutParams layoutParams = new LinearLayout.LayoutParams(
LinearLayout.LayoutParams.MATCH_PARENT,
LinearLayout.LayoutParams.MATCH_PARENT);
image.setLayoutParams(layoutParams);
image.setScaleType(ImageView.ScaleType.CENTER_CROP);

image.setImageBitmap(BitmapFactory.decodeFile(mImageUri));
new AsyncTask<Void, Void, Bitmap>() {
Copy link
Owner

@brk3 brk3 Dec 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing import for Bitmap

@Override
protected Bitmap doInBackground(Void... args) {
return BitmapFactory.decodeFile(mImageUri);
}

@Override
protected void onPostExecute(Bitmap bitmap) {
image.setImageBitmap(bitmap);
}
}.execute();

LinearLayout layout = new LinearLayout(getActivity());
layout.addView(image);
Expand Down
19 changes: 14 additions & 5 deletions app/src/main/java/com/bourke/glimmr/fragments/upload/LocalPhotosGridFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.net.Uri;
import android.os.AsyncTask;
import android.provider.MediaStore;
import android.support.v4.widget.CursorAdapter;
import android.util.Log;
Expand Down Expand Up @@ -240,7 +241,7 @@ public MediaStoreImagesAdapter(Context context, int layout, Cursor c,
@Override
public View getView(final int position, View convertView,
ViewGroup parent) {
ViewHolder holder;
final ViewHolder holder;
if (convertView == null) {
convertView = mActivity.getLayoutInflater().inflate(
R.layout.gridview_item, null);
Expand Down Expand Up @@ -271,12 +272,20 @@ public View getView(final int position, View convertView,
null);
Cursor thumbCursor = thumbCursorLoader.loadInBackground();

Bitmap myBitmap = null;
if(thumbCursor.moveToFirst()){
int thCulumnIndex = thumbCursor.getColumnIndex(THUMB_DATA);
String thumbPath = thumbCursor.getString(thCulumnIndex);
myBitmap = BitmapFactory.decodeFile(thumbPath);
holder.image.setImageBitmap(myBitmap);
final String thumbPath = thumbCursor.getString(thCulumnIndex);
new AsyncTask<Void, Void, Bitmap>() {
@Override
protected Bitmap doInBackground(Void... args) {
return BitmapFactory.decodeFile(thumbPath);
}

@Override
protected void onPostExecute(Bitmap myBitmap) {
holder.image.setImageBitmap(myBitmap);
}
}.execute();
}

/* Set tint on selected items */
Expand Down
29 changes: 20 additions & 9 deletions app/src/main/java/com/bourke/glimmr/fragments/viewer/PhotoViewerFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import android.graphics.Bitmap;
import android.media.MediaScannerConnection;
import android.net.Uri;
import android.os.AsyncTask;
import android.os.Bundle;
import android.os.Environment;
import android.util.Log;
Expand Down Expand Up @@ -444,15 +445,25 @@ private void saveImageToExternalStorage() {
String url = getLargestUrlAvailable(mBasePhoto);
new DownloadPhotoTask(mActivity, new Events.IPhotoDownloadedListener() {
@Override
public void onPhotoDownloaded(Bitmap bitmap, Exception e) {
String filename = mBasePhoto.getTitle() + ".jpg";
if (e == null && createExternalStoragePublicPicture(bitmap, filename) != null) {
Toast.makeText(mActivity, getString(R.string.image_saved), Toast.LENGTH_SHORT)
.show();
} else {
Toast.makeText(mActivity, getString(R.string.storage_error), Toast.LENGTH_SHORT)
.show();
}
public void onPhotoDownloaded(final Bitmap bitmap, final Exception e) {
final String filename = mBasePhoto.getTitle() + ".jpg";
new AsyncTask<Void, Void, File>() {
@Override
protected File doInBackground(Void... args) {
return createExternalStoragePublicPicture(bitmap, filename);
}

@Override
protected void onPostExecute(File file) {
if (e == null && file != null) {
Toast.makeText(mActivity, getString(R.string.image_saved), Toast.LENGTH_SHORT)
.show();
} else {
Toast.makeText(mActivity, getString(R.string.storage_error), Toast.LENGTH_SHORT)
.show();
}
}
}.execute();
}
}, url).execute();
}
Expand Down