Skip to content

Conversation

@LizBaldo
Copy link
Contributor

@LizBaldo LizBaldo commented Nov 25, 2025

Description

JIRA ticket: https://broadworkbench.atlassian.net/browse/CTM-163

I applied the migration on dev and it was successful. Will keep this PR open until the maintenance window of December 13th 2025.
Screenshot 2025-12-03 at 9 41 33 AM

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • [] I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@LizBaldo LizBaldo requested a review from a team as a code owner November 25, 2025 15:15
columnName="JOB_KEY_VALUE_ENTRY_ID"
columnDataType="BIGINT"
incrementBy="1"
startWith="20000000000"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the autoincrement reset is specific to an incident with call caching and should not be copied here. Can discuss in mob.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, will remove, thanks!

Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. One comment looks like it needs an update.

Threw a "do not merge" on as we want specific timing.

Comment on lines 8 to 9
<!-- For HSQLDB and Postgres database there are 2 changesets: one for modifying the table column type, and another one for altering the autoincrementing sequence.
The other DBs can be refactored similarly with a single addAutoIncrement changeset. The start of autoincrement is set at 20,000,000,000. -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is out of date, I think this file is a good match to what is happening here.

<!-- For Postgresql there are 2 changesets: one for modifying the table column type, and another one for altering the autoincrementing sequence.
The other DBs can be refactored similarly with a single addAutoIncrement changeset. -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants