-
Notifications
You must be signed in to change notification settings - Fork 376
CTM-163: Migrate job key value entry id from int to bigint #7827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| columnName="JOB_KEY_VALUE_ENTRY_ID" | ||
| columnDataType="BIGINT" | ||
| incrementBy="1" | ||
| startWith="20000000000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the autoincrement reset is specific to an incident with call caching and should not be copied here. Can discuss in mob.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, will remove, thanks!
aednichols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. One comment looks like it needs an update.
Threw a "do not merge" on as we want specific timing.
| <!-- For HSQLDB and Postgres database there are 2 changesets: one for modifying the table column type, and another one for altering the autoincrementing sequence. | ||
| The other DBs can be refactored similarly with a single addAutoIncrement changeset. The start of autoincrement is set at 20,000,000,000. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is out of date, I think this file is a good match to what is happening here.
cromwell/database/migration/src/main/resources/changesets/enlarge_sub_workflow_store_entry_id.xml
Lines 8 to 9 in 4884f73
| <!-- For Postgresql there are 2 changesets: one for modifying the table column type, and another one for altering the autoincrementing sequence. | |
| The other DBs can be refactored similarly with a single addAutoIncrement changeset. --> |
Description
JIRA ticket: https://broadworkbench.atlassian.net/browse/CTM-163
I applied the migration on dev and it was successful. Will keep this PR open until the maintenance window of December 13th 2025.

Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes