Open
Conversation
… the internal correct return, with process_time as None. Signed-off-by: yltony12 <yltony12@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This patch addresses a critical issue with the process_time. Specifically, it removes the finally block, which was unintentionally overwriting the correct internal return value, setting process_time to None.
Upon testing the validator code, I observed that the task process_time is consistently reported as 12 seconds, resulting in a speed score of 0.188875, regardless of the actual response time from miners.
The root cause of this issue is that the return statement in the finally block overwrites the return value from the try block, replacing it with None instead of the intended synapse.dendrite.process_time.
Additionally, you can verify this behavior in the W&B dashboard, where all timing metrics are recorded as 12 seconds.
Thanks & Merry Christmas :)