-
-
Notifications
You must be signed in to change notification settings - Fork 119
Add support for locks C30 & E330 #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
feat: Add Eufy Smart Lock C30 (T85D0) support - Add LOCK_85D0 device type with complete property set - Update all station methods for full C30 functionality - Add device detection and serial number recognition - Enable push notifications and event processing - Fix StationCommands corruption bug C30 locks now have full feature parity with C220/C210 models.
Adds a new method to determine if a device is a T85D0 lock, which is necessary for proper device identification and functionality within the application.
Adds support for detecting standard wifi locks and also considers the T8531 model.
For non-integrated locks connected to a separate HomeBase, the device's channel is now explicitly included in the unlock command payload. This ensures that the command is routed to the correct device. Adds channel parameter to debug log output.
|
Update: E330 now works for full features (lock status, locking & unlocking, battery). C30 is only missing the controlling feature (locking and unlocking) but reports everything else accurately. Tested locally. @martijnpoppen please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to see any changes as the whole file is reformatted. Please use the same indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, sorry about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest commit should show the changes there cleanly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sill shows 9k lines changed. Can you skip the prettier on the file?
We will enforce the prettier in the next few weeks but for now it is easier to keep as it is.
|
@max246 @bropat @martijnpoppen any review? |
sorry been busy on refactorig some code, will give a look tomorrow :) |
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "eufy-security-client", | |||
| "version": "3.1.1", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to rebase to the new develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sill shows 9k lines changed. Can you skip the prettier on the file?
We will enforce the prettier in the next few weeks but for now it is easier to keep as it is.
|
Just need to restore the formatting as it was before, sorry I know it is ugly but we will take care of it in the future, I have a PR open for it. And rebase so we dont have package changes. Then I will approve it. |
This adds support to C30 and E330 locks. It reports battery, lock status (unlocked or locked). I did expose a property to lock or unlock but that doesnt work. These locks dont support P2P afaik or im missing something. I suspect they use MQTT that I am not sure how to get working but atleast this is something better than nothing.