Skip to content

WIP commit to eliminate the ._vertices arrays from images. #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: horizon
Choose a base branch
from
Draft

WIP commit to eliminate the ._vertices arrays from images. #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
25a3009
WIP commit to eliminate the .vertices arrays from images. This commi…
Dec 27, 2020
a84a0b8
cleanup how chart and world libraries call render, to account for new…
Dec 27, 2020
ff9a6ef
handle runtime.wrap more carefully, to produce proper Pyret numbers w…
Dec 27, 2020
4882fdf
fix frame images not including the entire frame
Dec 28, 2020
b3b9273
Per https://github.com/brownplt/pyret-lang/issues/1562#issuecomment-7…
Dec 28, 2020
0cd2d5c
lazily compute ariaText descriptions
Dec 30, 2020
742e936
replacing DOMPoint/DOMMatrix with custom Point2D/Matrix implementatio…
Dec 30, 2020
ba4116a
missing flipX/Y methods
Dec 30, 2020
d472813
Progress:
Jan 3, 2021
943f9d1
cleanup stray console.logs and commented-out legacy code
Jan 3, 2021
73e203b
fix a test by putting the pinhole back at the geometric center rather…
Jan 4, 2021
0dd1a84
Merge remote-tracking branch 'origin/horizon' into fix-362
Feb 22, 2021
0656532
don't recall what this debugging code was for...
Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/web/js/trove/chart-lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,10 @@ ${labelRow}`;
const xPos = layout.getXLocation(data.getValue(i, 0));
const yPos = layout.getYLocation(data.getValue(i, 1));
const imgDOM = p[3].val.toDomNode();
p[3].val.render(imgDOM.getContext('2d'), 0, 0);
const ctx = imgDOM.getContext('2d');
ctx.translate(p[3].val.getWidth() / 2, p[3].val.getHeight() / 2);
ctx.translate(-p[3].val.getCenterX(), -p[3].val.getCenterY());
p[3].val.render(ctx);
// make an image element from the SVG namespace
let imageElt = document.createElementNS("http://www.w3.org/2000/svg", 'image');
imageElt.classList.add('__img_labels'); // tag for later garbage collection
Expand Down
Loading