Comprehensive jsnum tests #1818

ds26gte · 2025-09-20T12:37:42Z

This in-progress PR addresses Issue #1812.

A JS test file tests/jsnums-test/jsnums-test.c will test the methods and functions defined in js-numbers.js (Pyret's number library) that cannot be adequately tested by Pyret test files such as tests/pyret/tests/test-numbers.js.

This PR is WIP, and not ready to merge yet.

…t exercised by Pyret

- fromString(): for non-negative-exp sci not, avoid a division

- js-numbers.js returns _innards to allow more testing

- liftFixnumInteger: should produce valid Rational boxnum

- add test for toRepeatingDecimal

- test toStringDigits

- correct isInteger() def

schanzer · 2025-09-22T14:48:26Z

tests/jsnums-test/jsnums-test.js

+      expect(JN.fromString("1e140", sampleErrorBacks)).toEqual(JN.makeBignum("1e140"));
+
+      // for large bignums (> 1e140 ?), fromString() and makeBignum() can give structurally
+      // unequal results. so the following fail:


@ds26gte why are these commented out? We should be testing to make sure they fail, right?

The idea is that they should not fail, but were. I kept them around so I could solve the underlying problem as to why they were failing.

Now that I've canonicalized bigint representation -- i.e, every bigint now has a only one representation, not multiple as before --, these tests no longer fail, and are now uncommented.

- ensure integerNthRoot() is monotonically nondecreasing brownplt#1822 - require integerNthRoot() root and radicand to be non-neg - require nthRoot() root to be non-neg

** should remove fields at .t and above ** should remove any trailing zero fields, also reducing .t - bnDivide() should call clamp()

- test: bnToString _integerIsZero _integerIsOne _integerGcd

- _integer{Is{Zero,NegativeOne},Modulo,DivideToFixnum,{Greater,Less}Than{,OrEqual}} - splitIntIntoMantissaExpt

- bnpD{L,R}ShiftTo() should canonicalize

- test for: makeInteger{UnOp,Binop} - test for: bnpAddTo bnpDMultiply bnpMillerRabin - test for: bnRemainder bnModPow bnDivideAndRemainder bnIsProbablePrime

ds26gte · 2025-09-29T13:20:34Z

tests/jsnums-test/jsnums-test.js now includes 328 (!) tests for the functions defined in src/js/base/js-numbers.js. This includes tests for functions that are either not available to test as Pyret programs, or have some calls that are not exercised by Pyret programs.

While adding tests, found the following corrections that needed to be applied to js-numbers.js:

liftFixnumInteger() — despite name, make it accept all fixnums, not just fixnum ints. (This is because it is possible to leak non-int fixnums into this pipeline, and the rational number objects thus created are not only bogus but cause silent errors. Alternative is to make it error on non-ints.)
isInteger() — should return false on non-int fixnums. (Alternative is to make it error on non-int fixnums, which doesn't seem right)
numerator(), denominator(), remainder(), toStringDigits(), equals(), lessThan(), lessThanOrEqual() — propragate errbacks argument
Rational.*.numerator(), Rational.*.denominator(), Roughnum.*.numerator(), Roughnum.*.denominator(), BigInteger.*.numerator(), BigInteger.*.denominator() — should all take errbacks parameter
makeIntegerBinop(), makeIntegerUnOp — input & output functions should both take errbacks parameter
integerNthRoot() — should error on negative arguments. Initial guess should always be integer, or output is not monotonically non-decreasing
nthRoot() — should error on negative argument
bnpClamp() — ensure all unwanted fields are deleted, as also all non-significant 0-value fields. (This ensures unique representation for bigintegers — cleaner but also makes equality checks efficient)
bnpDLShiftTo(), bnpDRShiftTo(), bnDivide() — should use canonicalizer bnpClamp()
Returned module includes _innards field, which gives access to private functions so we can write JS tests for them
gcd(), lcm() simplified as we don't need to variadic arguments. Pyret num-gcd (as suggested by @blerner in add gcd operation? are the signatures the way we want? #1427), num-lcm defined

- toRational() methods take errbacks param even tho they don't use them

- runtime.js: gcd, lcm simplified as variable num args unneeded - add num-lcm also - image-lib.js: use simplified gcd - tests for num-gcd, num-lcm

ds26gte added 15 commits September 4, 2025 03:05

Added tests/jsnum-test.js to test methods in js-numbers.js that aren'…

f3a3930

…t exercised by Pyret

Merge branch 'fromFixnum-fix' into jsnum-tests

b414392

- jsnums-test.js: enhance brownplt#1812

a6485eb

- fromString(): for non-negative-exp sci not, avoid a division

fromString(): Rational.makeInstance already takes care of den == 1

812e409

- makeNumericBinop tests

a1837be

- js-numbers.js returns _innards to allow more testing

jsnums-tests.js: Add tests for Rational methods

f2d40dd

- more Rational.* tests

b8442a2

- liftFixnumInteger: should produce valid Rational boxnum

scrub unnecessary defs from jsnums-test.js

6e0e0ef

add Roughnum.* tests

74efc26

- add arrayEquals to help test structural equality

bc4f135

- add test for toRepeatingDecimal

- numerator, denominator methods take errbacks param

6beef5f

- test toStringDigits

Merge branch 'horizon' into jsnum-tests

66122ae

jsnums-test.js: add test for gcd, lcm

cc52770

- add tests for number predicates, sign, zfill, liftFixnumInteger

cb4e69e

- correct isInteger() def

add tests for number casts

1b7a85e

schanzer reviewed Sep 22, 2025

View reviewed changes

ds26gte added 8 commits September 22, 2025 15:34

- add tests for nthRoot() and integerNthRoot() brownplt#1812

e791660

- ensure integerNthRoot() is monotonically nondecreasing brownplt#1822 - require integerNthRoot() root and radicand to be non-neg - require nthRoot() root to be non-neg

- BigInteger canonicalizer bnpClamp() brownplt#1823

8c85b1f

** should remove fields at .t and above ** should remove any trailing zero fields, also reducing .t - bnDivide() should call clamp()

- test that bignums indeed have unique representations

74b589c

- test: bnToString _integerIsZero _integerIsOne _integerGcd

tests for

8d75cd8

- _integer{Is{Zero,NegativeOne},Modulo,DivideToFixnum,{Greater,Less}Than{,OrEqual}} - splitIntIntoMantissaExpt

- test BigInteger's {copy,sub,multiply,{d,}{l,r}Shift}To

3b9cad4

- bnpD{L,R}ShiftTo() should canonicalize

test for bnp{Squareto,DivRemTo,Exp,IsEven,ModInt}

cb5b948

- makeInteger{UnOp,Binop}: use & propagate errbacks appropriately

15914a9

- test for: makeInteger{UnOp,Binop} - test for: bnpAddTo bnpDMultiply bnpMillerRabin - test for: bnRemainder bnModPow bnDivideAndRemainder bnIsProbablePrime

test bnpToRadix

09a47af

ds26gte self-assigned this Sep 29, 2025

ds26gte requested review from jpolitz and blerner September 29, 2025 13:21

ds26gte added 2 commits September 29, 2025 10:33

- ensure all calls to equals(), lessThan{,OrEqual}() take errbacks

d727abd

- toRational() methods take errbacks param even tho they don't use them

test toRepeatingDecimal() for non-valid args

0bdd499

ds26gte mentioned this pull request Sep 29, 2025

Added missing 3rd (of 4) arg to jsnums.toRepeatingDecimal() calls #556 brownplt/code.pyret.org#588

Open

- add num-gcd courtesy @blerner brownplt#1427

00b90b9

- runtime.js: gcd, lcm simplified as variable num args unneeded - add num-lcm also - image-lib.js: use simplified gcd - tests for num-gcd, num-lcm

ds26gte mentioned this pull request Oct 3, 2025

add gcd operation? are the signatures the way we want? #1427

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comprehensive jsnum tests #1818

Comprehensive jsnum tests #1818

Uh oh!

ds26gte commented Sep 20, 2025

Uh oh!

schanzer Sep 22, 2025

Uh oh!

ds26gte Sep 29, 2025

Uh oh!

ds26gte commented Sep 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Comprehensive jsnum tests #1818

Are you sure you want to change the base?

Comprehensive jsnum tests #1818

Uh oh!

Conversation

ds26gte commented Sep 20, 2025

Uh oh!

schanzer Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

ds26gte Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

ds26gte commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ds26gte commented Sep 29, 2025 •

edited

Loading