Skip to content

Bug fix - few invalid caps being passed #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Bug fix - few invalid caps being passed #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6be3157
Initial commit
Jul 20, 2022
6500484
Modified Hub URL
abizer14 Jul 25, 2022
0ef375b
EOF fixes
Jul 25, 2022
ecc30fb
SingleTest fix for Firefox
Jul 25, 2022
da23138
Changed build name
Jul 25, 2022
a2da1fd
Removed SingleTest config + additional EOF files
Jul 27, 2022
1be1864
Updated README.md
abizer14 Jul 27, 2022
e78598b
Code refactor
Aug 4, 2022
e99351a
Updated Config.py
abizer14 Aug 8, 2022
70666ff
Bug fix - Fixed additional invalid caps getting added
Aug 12, 2022
21ecab9
Merge branch 'main' into main
abizer14 Aug 12, 2022
2d9334f
Minor whitespace fix
abizer14 Aug 12, 2022
bed237c
Bug fix for LocalTest.robot
Aug 24, 2022
b834440
Updated README.md
Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
Understand how many parallel sessions you need by using our [Parallel Test Calculator](https://www.browserstack.com/automate/parallel-calculator?ref=github)

## Notes
* This repository only works for Selenium 3 as of now. Desired Capabilities do not get honoured for Selenium 4. The open issue on SeleniumLibrary can be found [here](https://github.com/robotframework/SeleniumLibrary/issues/1774).
* This repository is for Selenium 3, for Selenium 4, refer to the selenium-4 branch.
* You can view your test results on the [BrowserStack Automate dashboard](https://www.browserstack.com/automate)
* To test on a different set of browsers, check out our [platform configurator](https://www.browserstack.com/automate/capabilities)

Expand Down
4 changes: 2 additions & 2 deletions config/KeywordsFile.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ ${remote_url}= https://hub.browserstack.com/wd/hub

*** Keywords ***
Open Session
[Arguments] ${capabilities} ${test_url}
open browser remote_url=${remote_url} desired_capabilities=${capabilities} url=${test_url}
[Arguments] ${capabilities} ${browsername} ${test_url}
open browser remote_url=${remote_url} desired_capabilities=${capabilities} url=${test_url} browser=${browsername}

Close Session
close browser
Expand Down
3 changes: 2 additions & 1 deletion tests/LocalTest.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ Test Teardown Teardown for local test

*** Variables ***
${local_url}= http://bs-local.com:45691/check
${browser}= chrome

*** Keywords ***
Setup for local test
START LOCAL
${final_caps}= combine caps 0
Set to Dictionary ${final_caps} name=BStack Demo - ${TEST NAME} browserstack.local=true
Open Session ${final_caps} ${local_url}
Open Session ${final_caps} ${browser} ${local_url}

Teardown for local test
Close Session
Expand Down
3 changes: 2 additions & 1 deletion tests/parallel/Suite01.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ Test Teardown Close Session

*** Variables ***
${website_url}= https://bstackdemo.com
${browser}= chrome

*** Keywords ***
Execute test
${final_caps}= combine caps 0
Set to Dictionary ${final_caps} name=BStack Demo - ${TEST NAME}
Open Session ${final_caps} ${website_url}
Open Session ${final_caps} ${browser} ${website_url}


*** Test Cases ***
Expand Down
3 changes: 2 additions & 1 deletion tests/parallel/Suite02.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ Test Teardown Close Session

*** Variables ***
${website_url}= https://bstackdemo.com
${browser}= safari

*** Keywords ***
Execute test
${final_caps}= combine caps 1
Set to Dictionary ${final_caps} name=BStack Demo - ${TEST NAME}
Open Session ${final_caps} ${website_url}
Open Session ${final_caps} ${browser} ${website_url}


*** Test Cases ***
Expand Down
3 changes: 2 additions & 1 deletion tests/parallel/Suite03.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ Test Teardown Close Session

*** Variables ***
${website_url}= https://bstackdemo.com
${browser}= chrome

*** Keywords ***
Execute test
${final_caps}= combine caps 2
Set to Dictionary ${final_caps} name=BStack Demo - ${TEST NAME}
Open Session ${final_caps} ${website_url}
Open Session ${final_caps} ${browser} ${website_url}


*** Test Cases ***
Expand Down