vmysql: expand remote_ip to store IPv6#16
Open
msimerson wants to merge 2 commits intobrunonymous:mainfrom
Open
vmysql: expand remote_ip to store IPv6#16msimerson wants to merge 2 commits intobrunonymous:mainfrom
msimerson wants to merge 2 commits intobrunonymous:mainfrom
Conversation
- expand user to match vpopmail table
Author
|
Why are most of the columns using CHAR instead of VARCHAR? Strikes me as a port by someone not familiar with MySQL. Would a PR that converts the CHAR column to VARCHAR be welcome? Run this query against your DB to see that VARCHAR is really a better choice: SELECT LENGTH(pw_name), LENGTH(pw_domain), LENGTH(pw_passwd), LENGTH(pw_gecos), LENGTH(pw_shell), LENGTH(pw_clear_passwd) FROM vpopmail.vpopmail;Would a PR that normalizes the SQL in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.