Skip to content

vmysql: expand remote_ip to store IPv6#16

Open
msimerson wants to merge 2 commits intobrunonymous:mainfrom
msimerson:vmysql-lengths
Open

vmysql: expand remote_ip to store IPv6#16
msimerson wants to merge 2 commits intobrunonymous:mainfrom
msimerson:vmysql-lengths

Conversation

@msimerson
Copy link
Copy Markdown

@msimerson msimerson commented Dec 6, 2024

  • expand vpopmail.lastauth.user to match length of vpopmail.pw_name

- expand user to match vpopmail table
@msimerson
Copy link
Copy Markdown
Author

Why are most of the columns using CHAR instead of VARCHAR? Strikes me as a port by someone not familiar with MySQL.

Would a PR that converts the CHAR column to VARCHAR be welcome? Run this query against your DB to see that VARCHAR is really a better choice:

SELECT LENGTH(pw_name), LENGTH(pw_domain), LENGTH(pw_passwd), LENGTH(pw_gecos), LENGTH(pw_shell), LENGTH(pw_clear_passwd) FROM vpopmail.vpopmail;

Would a PR that normalizes the SQL in vmysql.h so that it looks like a DBA wrote it be welcome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant