Remove use of Instruction::Ptr#87
Open
clementFoyer wants to merge 2 commits intobsc-performance-tools:masterfrom
Open
Remove use of Instruction::Ptr#87clementFoyer wants to merge 2 commits intobsc-performance-tools:masterfrom
clementFoyer wants to merge 2 commits intobsc-performance-tools:masterfrom
Conversation
Since commit dyninst/dyninst@9157d8a, the `Instruction::Ptr` type has been removed from Dyninst. Reflect this change onto extrae.
clementFoyer
force-pushed
the
fix-inst-ptr
branch
3 times, most recently
from
c8a3adc to
cdb5b5c
Compare
clementFoyer
force-pushed
the
fix-inst-ptr
branch
from
cdb5b5c to
007a3f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit dyninst/dyninst@9157d8a, the
Instruction::Ptrtype has been removed from Dyninst. Reflect this change onto extrae.It may need to be adapted to check the version of dyninst used in order to keep backward compatibility. Still, I keep this PR open for other users who may run into the same issue I encountered.