Add save to Clipboard#20
Open
valentin-seitz wants to merge 2 commits intobsc-performance-tools:masterfrom
Open
Add save to Clipboard#20valentin-seitz wants to merge 2 commits intobsc-performance-tools:masterfrom
valentin-seitz wants to merge 2 commits intobsc-performance-tools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds the functionality to save a Timeline window and the legend thereof to the clipboard.
Its extremely useful when working with larger traces and preparing slides as the current Save normally writes the image to the cluster filesystem. These files then need to be copied over manually.
I only tested it on my machine (standard Ubuntu22.04.5) and Marenostrum 5, but there it works like charm.
I also added some changes to prevent code replication in the
saveImagefunctionality.For the Legend there is still some duplicate code, but it would require a bigger refactoring of the current classes to remove it.
If you require this before this MR is accept i can give it a shot :)
Just let me know! :)
A preview:
