v0.5.2 - Currency Improvements #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add COP to SupportedCurrencies in currency service - Add COP option to settings currency selector - Add COP option to subscription form currency dropdown
The subscription list template was ignoring the enriched conversion data provided by the handler. Now displays converted cost with original currency below, matching the dashboard behavior. Fixes #79
- Add missing BRL (R$) and CHF (Fr.) to GetCurrencySymbol switch - Apply currency conversion display to subscriptions.html template - Add info icon with tooltip linking to Fixer.io for converted amounts - Tooltip explains 'Original amount before conversion (rates from Fixer.io)'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
internal/service/currency.go- Add COP to supported currenciesinternal/service/settings.go- Add BRL (R$) and CHF (Fr.) symbol mappingstemplates/settings.html- Add COP radio buttontemplates/subscription-form.html- Add COP dropdown optiontemplates/subscriptions.html- Fix conversion display + add info tooltiptemplates/subscription-list.html- Fix conversion display + add info tooltiptemplates/dashboard.html- Add info tooltip for conversionsTest plan
Closes #78, Closes #79