Skip to content

Compat with dotnet5 and PDN 4.3#9

Open
toehead2001 wants to merge 5 commits intobsneeze:masterfrom
toehead2001:pdn-4.3
Open

Compat with dotnet5 and PDN 4.3#9
toehead2001 wants to merge 5 commits intobsneeze:masterfrom
toehead2001:pdn-4.3

Conversation

@toehead2001
Copy link
Contributor

No description provided.

@toehead2001 toehead2001 marked this pull request as draft September 9, 2021 05:06
@toehead2001
Copy link
Contributor Author

This gets ScriptLab running in Paint.net v4.3

The plugin still has some hacky stuff that Rick probably doesn't like, but this will give you a headstart to any further changes you want to make.

@toehead2001 toehead2001 marked this pull request as ready for review September 10, 2021 01:52
@rickbrew
Copy link

Yeah this plugin will, at the very least, need to not do the AppDomain.CurrentDomain.AssemblyResolve hooking. That really breaks things and is a really bad idea in general. And I don't think the code is necessary anymore (I assume it was working around something); it's in FileMan.cs LoadFileXML and SaveFileXML

@rickbrew
Copy link

rickbrew commented Sep 10, 2021

The extension method, TryUseTileOrToSurface() is being marked internal in the next 4.3 build, so you'll need your own copy of that as well (can also just replace it with a call to ToSurface())

@rickbrew
Copy link

This PR would also need to use IEffectsService2 (new in v5.0, remember) instead of doing its own directory scanning, assembly loading, and instance creation. Otherwise it's not eligible to be published on the forum again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants