Added overridable methods for returing authz and token endpoints.

[alexdutton]

Previously the base ServiceProvider class didn't provide a default authorization_endpoint() and token_endpoint() implementation, and so always required the use of a sub-class (and ignoring the values passed to the OAuth2 constructor.

[btilly]

Please add documentation, and yourself to the Authors in whatever way
you want to be recognized.

On Fri, Dec 13, 2013 at 9:39 AM, Alexander Dutton
notifications@github.com wrote:

Previously the base ServiceProvider class didn't provide a default
authorization_endpoint() and token_endpoint() implementation, and so always
required the use of a sub-class (and ignoring the values passed to the
OAuth2 constructor.

---

You can merge this Pull Request by running

git pull https://github.com/ox-it/perl-oauth2 master

Or view, comment on, or merge it at:

#1

Commit Summary

Added overridable methods for returing authz and token endpoints.

File Changes

M lib/LWP/Authen/OAuth2/ServiceProvider.pm (15)

Patch Links:

https://github.com/btilly/perl-oauth2/pull/1.patch
https://github.com/btilly/perl-oauth2/pull/1.diff

[alexdutton]

I don't think I need to add any documentation as this adds functionality that was already documented — OAuth2.pm already says one can pass authorization_endpoint and token_endpoint parameters without needing to subclass, and ServiceProvider.pm says one can override the respective methods if one does decide to subclass.

[domm]

I also hit this bug, and implemented the exact same solution as alexsdutton, before I checked here and found that the bug is already fixed.

Please merge and release, so I can remove the ugly monkey-patch I currently have to use!

[domm]

I've applied your patches to my fork of LWP-Authen-OAuth2 and released a new version 0.08 to CPAN (Ben made me maintainer..)
But I cannot close the issue here...