Feat: Add header with timestamp and logo#5
Merged
btkcodedev merged 5 commits intobtkcodedev:mainfrom Mar 10, 2025
Merged
Conversation
Contributor
Author
|
@btkcodedev could yoy help to review please 🙏 |
btkcodedev
requested changes
Mar 4, 2025
Owner
btkcodedev
left a comment
btkcodedev
left a comment
There was a problem hiding this comment.
Left some lints, Thanks! Great work
src/components/header/index.tsx
Outdated
|
|
||
| </Sheet> | ||
| ); | ||
| } No newline at end of file |
src/components/header/index.tsx
Outdated
| @@ -0,0 +1,62 @@ | |||
| import * as React from 'react'; | |||
Owner
There was a problem hiding this comment.
Import useEffect, useState directly to avoid React. usage
src/components/header/index.tsx
Outdated
| export default function Header() { | ||
| const [currentTime, setCurrentTime] = React.useState<string>("") | ||
|
|
||
| React.useEffect(() => { |
Owner
There was a problem hiding this comment.
Avoid using React. for cleaner code
Owner
|
The PR name should be in convention |
joset98
changed the title
Contributor
Author
|
Thanks for feedback let me fix |
Owner
|
Yep, All good! |
btkcodedev
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the functionality to add a header to the application. The header displays the current timestamp and project logo, providing useful information and enhancing visual presentation.
Changes made:
Issue
#3
Screenshot