chore: fmt import sort #96
Merged
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Enables formatter-driven import sorting and updates tooling/docs to reflect that behavior.
Changes:
- Configure oxfmt to organize/sort imports (and separate import groups).
- Stop explicitly disabling
sort-importsin oxlint config. - Update CLAUDE.md to note that
pnpm formatperforms import sorting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CLAUDE.md | Documents that formatting now includes import sorting. |
| .oxlintrc.json | Removes explicit override disabling sort-imports. |
| .oxfmtrc.json | Enables oxfmt import organization/sorting configuration. |
| "$schema": "./node_modules/oxlint/configuration_schema.json", | ||
| "rules": { | ||
| "sort-imports": "off", | ||
| "@typescript-eslint/no-explicit-any": "error" |
There was a problem hiding this comment.
Removing the explicit sort-imports: off means whether oxlint enforces import ordering now depends on oxlint defaults. If sort-imports is enabled, this can also make the pre-commit hook flaky because lefthook.yml runs format and lint in parallel, so lint may run before oxfmt has re-ordered imports. Consider either explicitly configuring sort-imports here (to match the intended source of truth) or making the hook run lint after formatting.
Suggested change
| "@typescript-eslint/no-explicit-any": "error" | |
| "@typescript-eslint/no-explicit-any": "error", | |
| "sort-imports": "off" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.