fix: handle nil value in subspace.Get to prevent panic #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a parameter key does not exist in store (e.g., newly added CheckpointPollInterval parameter on existing nodes), the Get method would panic with 'UnmarshalJSON cannot decode empty bytes'. This fix returns early when bz is nil, allowing the ptr to keep its zero value. Callers can check if value > 0 to determine if it was set in the database, and fall back to config file defaults if needed.
- Update TestQueryParams to expect zero values instead of panic - Align test with the fix in params/subspace that returns early on nil
- Update TestQueryParams to expect zero values instead of panic - Align test with the fix in params/subspace that returns early on nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a parameter key does not exist in store (e.g., newly added CheckpointPollInterval parameter on existing nodes), the Get method would panic with 'UnmarshalJSON cannot decode empty bytes'.
This fix returns early when bz is nil, allowing the ptr to keep its zero value. Callers can check if value > 0 to determine if it was set in the database, and fall back to config file defaults if needed.