Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/cmd/fetcher/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"os"
"os/exec"
"path/filepath"
"slices"
"strings"
"time"

Expand Down Expand Up @@ -175,6 +176,12 @@ func run(ctx context.Context, root string) ([]createdPlugin, error) {
}
latestVersions[config.CacheKey()] = newVersion
}
// Some plugins share the same source but specify different ignore versions.
// Ensure we continue to only fetch the latest version once but still respect ignores.
if slices.Contains(config.Source.IgnoreVersions, newVersion) {
log.Printf("skipping source: %s: %v", config.Filename, newVersion)
continue
}
// example: plugins/grpc
pluginDir := filepath.Dir(config.Filename)
ok, err := checkDirExists(filepath.Join(pluginDir, newVersion))
Expand Down
3 changes: 2 additions & 1 deletion plugins/bufbuild/validate-java/source.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
source:
ignore_versions:
- v1.3.0 # Temporarily ignore version until a release is published.
# Temporarily ignore version until a release is published.
- v1.3.0
github:
owner: bufbuild
repository: protoc-gen-validate