Support older version of descriptor.proto#719
Merged
Conversation
emcfarlane
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proto3 support was introduced in
protocv3.0.0, however,ExtensionRangeOptionswas introduced inv3.4.0. If we wantto support vendoring WKTs (specifically
descriptor.proto) back tov3.0.0, we need to makeExtensionRangeOptionsoptional.This PR also adds a check when resolving option refs in general to
guard against missing
*Optionstypes indescriptor.proto. Previous tothis change, even in the case where we surface a diagnostic for a missing
required
descriptor.protofield, theoptionRef.resolve()code path willstill produce an ICE because it will attempt lower the unresolved
*Optionsfield. Instead, we provide a diagnostic at the options site to users in this case.