refactor(config): add validation for semantic_cache_threshold#2043
Merged
refactor(config): add validation for semantic_cache_threshold#2043
Conversation
Add Config::validate() check to ensure llm.semantic_cache_threshold is in [0.0, 1.0] and finite. Rejects NaN/Inf and out-of-range values at startup with actionable error message. Fixes #2036
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add validation for
llm.semantic_cache_thresholdconfig parameter to ensure values are in the valid range [0.0, 1.0] and are finite (rejecting NaN/Inf).Changes
Config::validate()after env overrides are applied. Validation runs once at bootstrap and rejects invalid values with an actionable error message.Validation Details
Config::validate()in loader.rs — catches all config load paths (TOML, env override, TUI, CLI)Test Results
Fixes
Fixes #2036