test(memory): add Ollama integration stubs for semantic cache (#2035)#2052
Merged
test(memory): add Ollama integration stubs for semantic cache (#2035)#2052
Conversation
github-actions
bot
added
tests
bug-ops
force-pushed
the
feat-issue-2035-ollama-integration
branch
from
f46a301 to
d418a88
Compare
Three #[ignore] integration tests in crates/zeph-memory/tests/ollama_integration.rs verify ResponseCache put_with_embedding/get_semantic roundtrip, semantic rephrase hits at threshold 0.80, and threshold boundary separation using live qwen3-embedding.
bug-ops
force-pushed
the
feat-issue-2035-ollama-integration
branch
from
d418a88 to
bc5f982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three integration tests for Ollama embedding validation in ResponseCache:
with_ollama_embedding: roundtrip embedding storage and retrieval at identity thresholdhit_on_rephrase: semantic retrieval with rephrase variance at threshold 0.80threshold_boundary: semantic similarity boundary separation at high (0.95) and low (0.0) thresholdsAll tests marked
#[ignore]— requires live Ollama instance with qwen3-embedding model.Fixes #2035
Review Summary
✓ Architecture reviewed and approved (architect + critic)
✓ Test coverage validated (tester pass)
✓ Security audit passed (security pass, LOW risk)
✓ Implementation quality approved (impl-critic approved, no blockers)
✓ Final code review approved (reviewer APPROVE)
All pre-commit checks pass:
cargo +nightly fmt --checkcargo clippy -p zeph-memory -- -D warningscargo build --tests -p zeph-memoryFiles
crates/zeph-memory/tests/ollama_integration.rs(new, 163 lines)Notes
.local/specs/2035-ollama-integration-tests/spec.mdfor detailed test specification