Conversation
github-actions
bot
added
enhancement
- Add probe prompts to step_context_compression(): enable/disable confirm, model input, threshold (0.0, 1.0], hard-fail threshold with cross-field validation loop (same pattern as soft/hard compaction thresholds) - Add probe_enabled, probe_model, probe_threshold, probe_hard_fail_threshold fields to WizardState with defaults (false, None, 0.6, 0.35) - Map WizardState probe fields to config.memory.compression.probe in build_config() - Add Config::validate() checks for probe thresholds when probe.enabled: threshold in (0.0, 1.0], hard_fail_threshold in [0.0, 1.0), hard_fail_threshold < threshold, max_questions >= 1, timeout_secs >= 1 - Add commented [memory.compression.probe] block to all three default.toml files so --migrate-config surfaces the section to users - Add unit tests: build_config_probe_* (6 cases), loader validate tests (5 cases), migrate_reference_contains_probe_section
bug-ops
force-pushed
the
feat/issue-2048/add-init-wizard-step-for-comp
branch
from
043e9c7 to
6eaf0b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #2048: adds
[memory.compression.probe]configuration option to the--initwizard and config migration.Users can now configure compaction probe settings interactively:
probe_enabled(default: false)probe_model(default: empty = inherits summary_model)probe_threshold(default: 0.6)hard_fail_threshold(default: 0.35)Config migration updates existing
zeph.tomlfiles to include the commented[memory.compression.probe]section.Changes
WizardState, probe prompts instep_context_compression(),build_config()mappingConfig::validate()checks for probe thresholds (mirrors soft/hard compaction validation pattern)[memory.compression.probe]block to all three locationsValidation
✅ All 6074 tests pass (+12 new)
✅ Formatter clean (
cargo +nightly fmt --check)✅ Clippy clean (
cargo clippy --workspace --features full -- -D warnings)✅ Nextest clean (
cargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins)Review Summary
Follow-up Issues (non-blocking)
To be filed after merge:
[memory.compression]configsmax_questions=0,timeout_secs=0Related
PR #2047 (compaction probe validation)