Open
Conversation
benkroop
force-pushed
the
feature/ina219_driver
branch
from
2aa71e0 to
73ce55a
Compare
benkroop
force-pushed
the
feature/ina219_driver
branch
from
73ce55a to
49c0836
Compare
jpanikulam
approved these changes
Apr 30, 2019
| static DriverConfiguration make_32V_1A(); | ||
| static DriverConfiguration make_16V_400mA(); | ||
|
|
||
| uint32_t current_divider_mA{0}; |
|
|
||
| #include "infrastructure/comms/schemas/message.hh" | ||
|
|
||
| #include <string> |
Member
There was a problem hiding this comment.
Looks like an unuse dinclude
| @@ -0,0 +1 @@ | |||
| #include "power_reading.hh" | |||
| /// @param reg - ID of the register to write to | ||
| /// @param value - The value to write | ||
| /// @return Returns true on success, false on failure | ||
| [[nodiscard]] bool write_register(Register reg, uint16_t value) const; |
Member
There was a problem hiding this comment.
Consider returning an optional instead of an output argument + bool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an ina219 driver and a current sensing BQ.