Quick fixes from Bazel-ification#151
Open
m3rcuriel wants to merge 2 commits intobuild-week:masterfrom
Open
Conversation
benkroop
approved these changes
Jul 6, 2019
jpanikulam
requested changes
Jul 7, 2019
Member
jpanikulam
left a comment
There was a problem hiding this comment.
Hey Lee, nice changes
Please comment something to the effect of "I hereby assign copyright in this code to the project, to be licensed under the same terms as the rest of the code."
Author
|
I hereby assign copyright in this code to the project, to be licensed under the same terms as the rest of the code. Also I'll put it there to but the above applies to any of my work on my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a few really quick things -- system includes for including things that are from the project as well as some catch-by-value.