Open
Conversation
benkroop
requested changes
Aug 4, 2019
Contributor
benkroop
left a comment
benkroop
left a comment
There was a problem hiding this comment.
Looks good overall. A few nits.
| { | ||
| throw std::runtime_error("Couldn't open file: " + file_path); | ||
| if (!get_logfile(channel, channel_name)) { | ||
| throw std::runtime_error("Couldn't open file for " + channel_name); |
Contributor
There was a problem hiding this comment.
It may still be useful to include the filename in the throw exception string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where camera images seem to cut out earlier than all other logged data. Turns out we aren't reading all of the log!