Replace environment bootstrap with direnv#169
Open
khaledhassan wants to merge 2 commits intomasterfrom
Open
Conversation
khaledhassan
commented
Jun 19, 2023
| @@ -39,6 +39,10 @@ git pull --rebase origin master | |||
| ./infrastructure/scripts/environment_bootstrap.sh | |||
| ``` | |||
Author
There was a problem hiding this comment.
If this looks good, better to remove the environment_bootstrap.sh script and instructions so as to not maintain 2 sets of bootstrap scripts? (Then again, not a huge burden as the environment_bootstrap.sh has not changed much 😄 )
Author
benkroop
approved these changes
Sep 26, 2023
rleyva
approved these changes
Feb 14, 2024
Contributor
rleyva
left a comment
rleyva
left a comment
There was a problem hiding this comment.
Looks good to me - should we try and land this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
direnvto initialize environment variables - this prevents the need to bake theinfrastructure/scriptsdir into your~/.bashrcdirectly, by automatically loading/unloading when you enter/leave your working copy directory