Skip to content

Conversation

@EdSchouten
Copy link
Member

THis requires us to catch up with the following API changes:

  • The go-winfsp package has changed owners. Patch up all imports.

  • pkg/digest's NewHasher() and NewGenerator() now require the expected size to be exact. Call FileReader.Len() to obtain the file's size.

  • Change HoleSource to no longer inherit FileReader, as we shouldn't provide an implementation of Len().

THis requires us to catch up with the following API changes:

- The go-winfsp package has changed owners. Patch up all imports.

- pkg/digest's NewHasher() and NewGenerator() now require the expected
  size to be exact. Call FileReader.Len() to obtain the file's size.

- Change HoleSource to no longer inherit FileReader, as we shouldn't
  provide an implementation of Len().
@aspect-workflows
Copy link

aspect-workflows bot commented Jan 27, 2026

Test

18 test targets passed

Targets
//pkg/blobstore:blobstore_test [k8-fastbuild]                                         66ms
//pkg/builder:builder_test [k8-fastbuild]                                             210ms
//pkg/cas:cas_test [k8-fastbuild]                                                     67ms
//pkg/cleaner:cleaner_test [k8-fastbuild]                                             73ms
//pkg/clock:clock_test [k8-fastbuild]                                                 88ms
//pkg/filesystem/access:access_test [k8-fastbuild]                                    157ms
//pkg/filesystem/pool:pool_test [k8-fastbuild]                                        216ms
//pkg/filesystem/virtual/fuse:fuse_test [k8-fastbuild]                                180ms
//pkg/filesystem/virtual/nfsv4:nfsv4_test [k8-fastbuild]                              187ms
//pkg/filesystem/virtual:virtual_test [k8-fastbuild]                                  136ms
//pkg/filesystem:filesystem_test [k8-fastbuild]                                       152ms
//pkg/runner:runner_test [k8-fastbuild]                                               74ms
//pkg/scheduler/initialsizeclass:initialsizeclass_test [k8-fastbuild]                 66ms
//pkg/scheduler/invocation:invocation_test [k8-fastbuild]                             105ms
//pkg/scheduler/platform:platform_test [k8-fastbuild]                                 102ms
//pkg/scheduler/routing:routing_test [k8-fastbuild]                                   110ms
//pkg/scheduler:scheduler_test [k8-fastbuild]                                         429ms
//pkg/sync:sync_test [k8-fastbuild]                                                   43ms

Total test execution time was 2s. 1 test (5.3%) was fully cached saving 97ms.

@EdSchouten EdSchouten merged commit 79a33f1 into main Jan 27, 2026
3 checks passed
@EdSchouten EdSchouten deleted the eschouten/20260127-upgrade branch January 27, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants