Add support for digest function GITSHA1 #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this digest function has enum value 10, we need to tidy up some code in digest.go that assumed that all digest functions can be represented as a single digit.
|
NewGenerator() and NewHasher() require providing the exact size of a file. However, our VFS API provides no way of obtaining it without reading its contents. I'm naming this method Len() to match bytes.Buffer and strings.Buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this digest function has enum value 10, we need to tidy up some code in digest.go that assumed that all digest functions can be represented as a single digit.
bazelbuild/remote-apis#352