Skip to content

feat: trading ops, backtesting, and agent bridge panels#511

Open
IvanZaro wants to merge 1 commit intobuilderz-labs:mainfrom
IvanZaro:feat/trading-ops-backtesting-agent-bridge
Open

feat: trading ops, backtesting, and agent bridge panels#511
IvanZaro wants to merge 1 commit intobuilderz-labs:mainfrom
IvanZaro:feat/trading-ops-backtesting-agent-bridge

Conversation

@IvanZaro
Copy link
Copy Markdown

Summary

  • Phase 2: Agent status table, detail panel, status badge, data table, useAgentStatus hook, and agent status API
  • Phase 3: Transaction cost model, deploy gate modal, agent control/halt APIs, emergency halt button, trading config editor
  • Phase 4: Backtest results panel with summary stats and detail slide-out, backtest API with auto-table creation
  • Phase 5: 13 typed agent event interfaces, event ingestion API with auth and side effects, chat bridge panel
  • Integrates DESIGN.md dark theme into globals.css, layout, nav-rail, and tailwind config

New Files (20)

  • 7 API routes (agents/control, agents/halt, agents/status, backtest, config/trading, deploy/assess, events/ingest)
  • 5 components (deploy-gate, agent-table, agent-detail-panel, backtest-results-panel, chat-bridge-panel)
  • 4 UI primitives (halt-button, status-badge, connection-pill, data-table)
  • 2 type modules (agent-events, agent-status)
  • 1 hook (use-agent-status)
  • 1 lib (transaction-costs)

Test plan

  • TypeScript: zero errors (npx tsc --noEmit)
  • ESLint: zero warnings on all new files
  • Vitest: 863/875 pass (12 pre-existing failures — Windows paths + stale theme tests)
  • All 20 new files verified for proper exports and structure

🤖 Generated with Claude Code

Phase 2: Agent status table, detail panel, connection pill, status badge,
data table, useAgentStatus hook, and agent status API.

Phase 3: Transaction cost model, deploy gate modal, agent control/halt
APIs, emergency halt button, and trading config editor API.

Phase 4: Backtest results panel with summary stats and detail slide-out,
backtest API with auto-table creation (5 strategies x 3 symbols).

Phase 5: 13 typed agent event interfaces, event ingestion API with
auth and side effects, and chat bridge panel for agent commands.

Also integrates DESIGN.md dark theme into globals.css, layout, nav-rail,
theme-background, and tailwind config.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@IvanZaro IvanZaro requested a review from 0xNyk as a code owner March 26, 2026 13:50
@0xNyk
Copy link
Copy Markdown
Member

0xNyk commented Mar 31, 2026

Triage outcome: not merge-ready.

Blocking factors:

  • Merge conflicts (DIRTY/conflicting)
  • Large multi-feature blast radius in one PR
  • No active checks currently attached

Please split into smaller PRs (API, UI panels, theme/system changes), rebase on latest main, and rerun full quality gate.

@0xNyk
Copy link
Copy Markdown
Member

0xNyk commented Mar 31, 2026

Triage enforcement update from maintainers:\n\nStatus: not mergeable in current form.\n\nBlocking reasons:\n- PR is conflicting with main.\n- Large multi-feature scope (trading ops + backtesting + bridge panels) with high review surface.\n- Missing completed review/check cycle for this branch state.\n\nRequired path forward:\n1) Rebase and split into phased PRs by feature area.\n2) Add per-phase acceptance criteria and tests.\n3) Land incrementally behind guarded UI flags if needed.\n\nRecommendation: close and relaunch as phased implementation PRs.\n

@0xNyk
Copy link
Copy Markdown
Member

0xNyk commented Mar 31, 2026

Tracking replacement scope in #540. Recommend closing this PR in favor of the scoped implementation issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants