Fix length unit of projected crs to match map conversion.#4
Open
SGoetschi wants to merge 1 commit intobuildingsmart-community:mainfrom
Open
Fix length unit of projected crs to match map conversion.#4SGoetschi wants to merge 1 commit intobuildingsmart-community:mainfrom
SGoetschi wants to merge 1 commit intobuildingsmart-community:mainfrom
Conversation
The eastings and northings values in the IFCMAPCONVERSION are obviously in millimeters. But the IFCPROJECTEDCRS was set up with meters as units. Moving this over to millimeters will correctly position the file.
Author
|
This adds the same change as this PR on the old version of this repository. |
|
Sorry to hijack, did you by any chance also review https://github.com/buildingSMART/IFC4.3.x-sample-models/tree/main/models/placements-and-gis-referencing Never hurts to have more eyes on the samples. |
Author
|
From what I can see the geographic-referencing-gk and geographic-referencing-utm are correct - at least in regard to units. But I don't know enough about grid placement and rigid operation to say anything about those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General pull request
Fixes wrong position of example project location.
Changes and improvements proposed by this pull request
IFC 4.0.2.1 (IFC 4)/Example project location/example project location.ifc:The eastings and northings values in the IFCMAPCONVERSION are obviously in millimeters. But the IFCPROJECTEDCRS was set up with meters as units. Moving this over to millimeters will correctly position the file.