Merge pull request #2439 from buildkite/main-id

dannymidnight · web-flow · commit 9bd0f098e825 · 2023-08-28T14:40:48.000+10:00
Attempt to fix blank search records
diff --git a/app/models/page/renderer.rb b/app/models/page/renderer.rb
@@ -75,13 +75,6 @@ def add_automatic_ids_to_headings(doc)
     h2_ids = []
     h3s_with_manual_ids = []
 
-    # h1 headers
-    doc.search('./h1').each do |header|
-      if (id = header['id']).blank?
-        id = header['id'] = header.text.to_url
-      end
-    end
-
     # h2 headers
     doc.search('./h2').each do |h2|
       if (id = h2['id']).blank?
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -6,7 +6,7 @@
   <body class="<%= beta? ? 'beta' : ''-%>">
     <%= render "site_header" %>
 
-    <main id="main" role="main">
+    <main id="__main" role="main">
       <div class="PageContainer">
         <div class="Page">
           <div class="Page__sidebar">
diff --git a/pages/agent/v3/gcloud.md b/pages/agent/v3/gcloud.md
@@ -52,7 +52,7 @@ Metrics-server is running at https://34.71.166.83/api/v1/namespaces/kube-system/
 To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.
 ```
 
-Create a [secret](https://kubernetes.io/docs/concepts/configuration/secret/#using-secrets-as-environment-variables) with your [agent registration token](/docs/agent/v3/tokens#main):
+Create a [secret](https://kubernetes.io/docs/concepts/configuration/secret/#using-secrets-as-environment-variables) with your [agent registration token](/docs/agent/v3/tokens):
 
 ```shell
 $ kubectl create secret generic buildkite-agent --from-literal=token=INSERT-YOUR-AGENT-TOKEN-HERE
diff --git a/spec/models/page/renderer_spec.rb b/spec/models/page/renderer_spec.rb
@@ -8,7 +8,7 @@
     MD
 
     html = <<~HTML
-      <h1 id="page-title">Page title</h1>
+      <h1>Page title</h1>
 
       <p>Some description</p>
     HTML
