Conversation
pda
approved these changes
Jun 20, 2025
…y and readability
joshuay03
force-pushed
the
redis-clustering-support
branch
from
5df7776 to
4c49eae
Compare
This was referenced Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context in ParentSquare#71
Additional context for @buildkite folks in https://github.com/buildkite/buildkite/pull/22829
This is a clean cherry pick of the following commits to my personal fork where I could freely iterate and run the CI workflow:
My goal is to merge this and point the bk/bk Gemfile to the ref temporarily so I can take my time upstreaming this work, which I've kicked off with ParentSquare#72.
The spec suite was able to replicate the error I reported in ParentSquare#71, as well as the cross-slot errors @pda came across, so I'm quite confident that if this builds green on non-head ruby versions we're good to go.