feat: add --safe-address option and isV2 query param#12
Merged
Conversation
…ap-credit - Add optional --safe-address flag to underwrite and tap-credit commands - When provided, use safe address in URL instead of JWT wallet address - Append account_type=gnosis query param when acting as a safe - Add isV2=true query param to underwrite endpoint - Add e2e tests verifying safe address routing and query params
Contributor
Author
|
🎉 This PR is included in version 0.0.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--safe-addressflag tounderwriteandtap-creditcommandsaccount_type=gnosisquery param when acting as a safeisV2=truequery param to the underwrite endpointTest plan
account_type=gnosisquery param is present when--safe-addressis used--safe-address🤖 Generated with Claude Code