feat: add approve commands (create-claim, nft, erc20) by GeraldBennyClawBot · Pull Request #8 · bulla-network/bulla-cli

GeraldBennyClawBot · 2026-03-16T18:01:53Z

Implements DEV-2391. Adds bulla approve subcommand with three operations: create-claim (BullaApprovalRegistry.approveCreateClaim), nft (BullaClaimV2.approve ERC721), erc20 (ERC20.approve). Each has build and execute variants. Adds ABIs, domain types, encoder port/adapter, service layer, CLI options/validation/commands, and registry support for bullaApprovalRegistry + bullaClaimV2 addresses.

Add `bulla approve` subcommand with three operations: - `create-claim` — BullaApprovalRegistry.approveCreateClaim - `nft` — BullaClaimV2.approve (ERC721) - `erc20` — ERC20.approve Each has build (unsigned tx) and execute (sign+send) variants. Adds ABIs, domain types, encoder port/adapter, service layer, CLI options/validation/commands, and registry support for bullaApprovalRegistry + bullaClaimV2 contract addresses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

src/application/services/approve-service.ts

src/cli/approve/options.ts

src/cli/approve/validation.ts

src/index.ts

- Set 'approved' as default for --approval-type option - Add explicit validateApprovalType() with InvalidApprovalTypeError - Add unit tests for approve service (11 tests) and validation (16 tests) - Add e2e tests for all 3 approve build commands + help output Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bengobeil

Still no support for approve transfers for BullaInvoice and BullaFrendLendV2. Write tests to confirm. Perhaps the whole e2e flow would be: mint invoice, approve transfer, then transfer, check that nft has changed ownership

bengobeil

Still no support for approve transfers for BullaInvoice and BullaFrendLendV2

Adds `bulla invoice approve-nft` and `bulla frendlend approve-nft` subcommands. Removes standalone `bulla approve nft`. Both target BullaClaimV2 via the registry since all claims are ERC721 on that contract regardless of which controller created them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

GeraldBennyClawBot · 2026-03-16T19:22:18Z

Pushed changes: approve-nft is now a subcommand on both invoice and frendlend (e.g. bulla invoice approve-nft build/execute, bulla frendlend approve-nft build/execute). Removed the standalone bulla approve nft command — bulla approve now only has create-claim and erc20. Added e2e tests for both new paths. All 172 unit tests + 8 e2e tests pass, typecheck clean.

test/e2e/approve.e2e.test.ts

src/application/services/approve-service.ts

…t commands - buildApproveNft now targets the controller contract (BullaInvoice or BullaFrendLendV2) for controlled claims, not BullaClaimV2 directly - Added transfer-nft subcommand to invoice and frendlend - Added full lifecycle e2e tests: mint -> approve -> transfer -> verify ownership (per claim type, execute mode with anvil) - Extended BullaClaimV2 ABI with transferFrom and ownerOf Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

GeraldBennyClawBot · 2026-03-16T19:52:21Z

Addressed all 3 review comments: (1) approve-nft and transfer-nft now target the controller contract (BullaInvoice or BullaFrendLendV2) instead of BullaClaimV2 directly. (2) Full lifecycle e2e tests using execute mode with anvil: invoice create->approve->transfer->check ownership, frendlend offer->accept->approve->transfer->check ownership. (3) Added invoice transfer-nft and frendlend transfer-nft subcommands. 178 unit + 4 e2e tests pass, 9 lifecycle tests skipped without anvil.

Uses publicnode.com Sepolia RPC as default when SEPOLIA_RPC_URL env var is not set, so approve/transfer lifecycle tests always run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

GeraldBennyClawBot · 2026-03-16T19:58:38Z

Round 3 review — all feedback addressed

1. `approve-nft` now targets the controller contract

buildApproveNft accepts a getContractAddress callback that determines where the approve tx is sent
Invoice approve-nft → targets BullaInvoice controller address (not BullaClaimV2)
FrendLend approve-nft → targets BullaFrendLendV2 controller address
Helper functions: getInvoiceControllerAddress, getFrendLendControllerAddress, getClaimContractAddress

2. `transfer-nft` commands added

bulla invoice transfer-nft build/execute — transfers invoice NFTs via BullaInvoice controller
bulla frendlend transfer-nft build/execute — transfers loan NFTs via BullaFrendLendV2 controller
Same getContractAddress callback pattern as approve-nft

3. Full lifecycle e2e tests (execute mode)

Invoice lifecycle (4 tests):

Create invoice (mint) → get claimId
invoice approve-nft execute → approve account1
invoice transfer-nft execute → transfer NFT to account1
Verify ownerOf(claimId) changed to account1

FrendLend lifecycle (5 tests):

Offer loan → get offerId
Accept loan → get claimId, verify initial owner
frendlend approve-nft execute → approve account1
frendlend transfer-nft execute → transfer NFT to account1
Verify ownerOf(claimId) changed to account1

4. Public Sepolia RPC fallback

SEPOLIA_RPC_URL defaults to https://ethereum-sepolia-rpc.publicnode.com when env var is not set
Approve/transfer lifecycle tests no longer skip — they always run

CI passing ✅ (178 unit tests + 8 e2e build tests, typecheck clean)

src/application/services/approve-service.ts

src/cli/invoice/commands.ts

src/application/services/approve-service.ts

src/infrastructure/encoding/viem-approve-encoder.ts

- Create NftTransferService as Effect Context service with buildApproveNft and buildTransferNft methods - Use Layer.effect factory (makeNftTransferServiceLayer) to create controller-specific service instances (Invoice, FrendLend, Claim) - Provide NftTransferService via pipe in invoice/frendlend commands - Switch from transferFrom to safeTransferFrom for NFT transfers - Clean up approve-service.ts to only contain create-claim and ERC20 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

safeTransferFrom through the controller reverts with ERC721InsufficientApproval when called by an approved (non-owner) party on the deployed Sepolia contracts. transferFrom works correctly for the same flow (approve → transfer by approved party). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bengobeil

use SafeTransferFrom

The 3-arg safeTransferFrom(address,address,uint256) is an external wrapper that internally calls the 4-arg public version. By calling the 4-arg safeTransferFrom(address,address,uint256,bytes) directly with empty bytes, we avoid any msg.sender issues in the external-to-public delegation path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Hardhat's well-known test accounts (0xf39Fd6e..., 0x70997970...) have EOF contracts deployed on Sepolia, causing safeTransferFrom to call onERC721Received and revert. Clear account code via anvil_setCode after fork starts so these addresses behave as EOAs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bengobeil · 2026-03-16T21:06:17Z

🎉 This PR is included in version 0.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

bengobeil requested changes Mar 16, 2026

View reviewed changes

src/application/services/approve-service.ts Outdated Show resolved Hide resolved

src/cli/approve/options.ts Outdated Show resolved Hide resolved

src/cli/approve/validation.ts Outdated Show resolved Hide resolved

src/index.ts Show resolved Hide resolved

bengobeil requested changes Mar 16, 2026

View reviewed changes

test/e2e/approve.e2e.test.ts Outdated Show resolved Hide resolved

src/application/services/approve-service.ts Outdated Show resolved Hide resolved

fix: use public Sepolia RPC fallback for e2e tests

3872c8d

Uses publicnode.com Sepolia RPC as default when SEPOLIA_RPC_URL env var is not set, so approve/transfer lifecycle tests always run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bengobeil requested changes Mar 16, 2026

View reviewed changes

bengobeil approved these changes Mar 16, 2026

View reviewed changes

bengobeil requested changes Mar 16, 2026

View reviewed changes

Gerald (AI Assistant) and others added 2 commits March 16, 2026 16:43

bengobeil approved these changes Mar 16, 2026

View reviewed changes

bengobeil merged commit 874350a into main Mar 16, 2026
1 check passed

bengobeil added the released label Mar 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add approve commands (create-claim, nft, erc20)#8

feat: add approve commands (create-claim, nft, erc20)#8
bengobeil merged 9 commits intomainfrom
gerald/dev-2391-approve-functions-cli

GeraldBennyClawBot commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bengobeil left a comment

Uh oh!

bengobeil left a comment

Uh oh!

GeraldBennyClawBot commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

GeraldBennyClawBot commented Mar 16, 2026

Uh oh!

GeraldBennyClawBot commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bengobeil left a comment

Uh oh!

Uh oh!

bengobeil commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

GeraldBennyClawBot commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bengobeil left a comment

Choose a reason for hiding this comment

Uh oh!

bengobeil left a comment

Choose a reason for hiding this comment

Uh oh!

GeraldBennyClawBot commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

GeraldBennyClawBot commented Mar 16, 2026

Uh oh!

GeraldBennyClawBot commented Mar 16, 2026

Round 3 review — all feedback addressed

1. approve-nft now targets the controller contract

2. transfer-nft commands added

3. Full lifecycle e2e tests (execute mode)

4. Public Sepolia RPC fallback

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bengobeil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bengobeil commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

1. `approve-nft` now targets the controller contract

2. `transfer-nft` commands added