feat: add factoring pool view commands (DEV-2461)#9
Merged
Conversation
…EV-2461) Add 7 new view commands to the factoring CLI: - price: read pricePerShare() - balance: read balanceOf(address) with --account option - total-assets: read totalAssets() - total-supply: read totalSupply() - active-invoices: read activeInvoices(index) with --index option - max-redeem: read maxRedeem(owner) with --account option - paid-invoices-gain: read paidInvoicesGain() Fix getFundInfo reader to map all 9 struct fields from the contract (name, creationTimestamp, fundBalance, deployedCapital, capitalAccount, price, tokensAvailableForRedemption, adminFeeBps, targetYieldBps) instead of incorrectly mapping only 4 fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bengobeil
requested changes
Mar 18, 2026
Contributor
bengobeil
left a comment
bengobeil
left a comment
There was a problem hiding this comment.
Any tests that we can write here?
The fund-info e2e test was checking for the old incorrect field names (totalAssets, totalSupply). Updated to check for the correct contract struct fields (name, fundBalance, deployedCapital, etc.). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bengobeil
approved these changes
Mar 18, 2026
Contributor
|
🎉 This PR is included in version 0.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 7 new view commands (price, balance, total-assets, total-supply, active-invoices, max-redeem, paid-invoices-gain) and fixes getFundInfo reader to map all 9 struct fields instead of 4. Fixes DEV-2461