Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Python 3.13 to the project by updating dependency configurations and CI workflows. The implementation includes version-specific dependency constraints and excludes problematic test combinations.
- Adds Python 3.13 to the test matrix in GitHub Actions workflow
- Updates dependency version constraints for Python 3.13 compatibility
- Excludes windows-latest + Python 3.13 test combination due to known issues
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Updates dependency version constraints with Python 3.13-specific requirements for lxml and onnxruntime |
| .github/workflows/runtests.yml | Adds Python 3.13 to test matrix and excludes problematic windows-latest combination |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| shapely = { version = "<=2.0.1", markers = "python_version <= '3.8'"} | ||
| lxml = [ { version = "^4.9.3", markers = "python_version < '3.13'"}, | ||
| { version = ">4.9.4", markers = "python_version >= '3.13'"}] |
There was a problem hiding this comment.
[nitpick] The array formatting is inconsistent with spacing. Consider formatting as [{version = "^4.9.3", markers = "python_version < '3.13'"}, {version = ">4.9.4", markers = "python_version >= '3.13'"}] for better readability.
| { version = ">4.9.4", markers = "python_version >= '3.13'"}] | |
| lxml = [ | |
| {version = "^4.9.3", markers = "python_version < '3.13'"}, | |
| {version = ">4.9.4", markers = "python_version >= '3.13'"} | |
| ] |
|
|
||
| # 1.16.0 problem: https://github.com/microsoft/onnxruntime/issues/17631 | ||
| onnxruntime = ">1.10.0,!=1.16.0" | ||
| onnxruntime = [{version=">1.10.0,!=1.16.0", markers= "python_version >='3.10'"}, |
There was a problem hiding this comment.
[nitpick] Inconsistent spacing around the equals sign in markers= "python_version >='3.10'". Should be markers = "python_version >= '3.10'" to match the formatting style used elsewhere.
| onnxruntime = [{version=">1.10.0,!=1.16.0", markers= "python_version >='3.10'"}, | |
| onnxruntime = [{version=">1.10.0,!=1.16.0", markers = "python_version >= '3.10'"}, |
Add support for python 3.13
All tests passed except
windows-latestandpython3.13, created an issue #159 for that and disabled test execution on this setup for now.