Skip to content

Feat: Add python3.13 support#160

Merged
AndreasFischer1985 merged 4 commits intomainfrom
rw/python3.13-support
Aug 17, 2025
Merged

Feat: Add python3.13 support#160
AndreasFischer1985 merged 4 commits intomainfrom
rw/python3.13-support

Conversation

@wirthual
Copy link
Member

Add support for python 3.13

All tests passed except windows-latest and python3.13, created an issue #159 for that and disabled test execution on this setup for now.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Python 3.13 to the project by updating dependency configurations and CI workflows. The implementation includes version-specific dependency constraints and excludes problematic test combinations.

  • Adds Python 3.13 to the test matrix in GitHub Actions workflow
  • Updates dependency version constraints for Python 3.13 compatibility
  • Excludes windows-latest + Python 3.13 test combination due to known issues

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Updates dependency version constraints with Python 3.13-specific requirements for lxml and onnxruntime
.github/workflows/runtests.yml Adds Python 3.13 to test matrix and excludes problematic windows-latest combination
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


shapely = { version = "<=2.0.1", markers = "python_version <= '3.8'"}
lxml = [ { version = "^4.9.3", markers = "python_version < '3.13'"},
{ version = ">4.9.4", markers = "python_version >= '3.13'"}]
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The array formatting is inconsistent with spacing. Consider formatting as [{version = "^4.9.3", markers = "python_version < '3.13'"}, {version = ">4.9.4", markers = "python_version >= '3.13'"}] for better readability.

Suggested change
{ version = ">4.9.4", markers = "python_version >= '3.13'"}]
lxml = [
{version = "^4.9.3", markers = "python_version < '3.13'"},
{version = ">4.9.4", markers = "python_version >= '3.13'"}
]

Copilot uses AI. Check for mistakes.

# 1.16.0 problem: https://github.com/microsoft/onnxruntime/issues/17631
onnxruntime = ">1.10.0,!=1.16.0"
onnxruntime = [{version=">1.10.0,!=1.16.0", markers= "python_version >='3.10'"},
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent spacing around the equals sign in markers= "python_version >='3.10'". Should be markers = "python_version >= '3.10'" to match the formatting style used elsewhere.

Suggested change
onnxruntime = [{version=">1.10.0,!=1.16.0", markers= "python_version >='3.10'"},
onnxruntime = [{version=">1.10.0,!=1.16.0", markers = "python_version >= '3.10'"},

Copilot uses AI. Check for mistakes.
@AndreasFischer1985 AndreasFischer1985 merged commit c7299b8 into main Aug 17, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants