Skip to content
This repository was archived by the owner on Mar 5, 2022. It is now read-only.

Conversation

dereuromark
Copy link
Collaborator

@dereuromark dereuromark changed the title Add width/height Fix upload for edit Nov 15, 2020
{
$data = [
'id' => $file->uuid(),
'id' => $file->uuid(), //FIXME
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to set the id for primary key records?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The File object doesn't care, because the whole lib doesn't care about persistance (its not their job) but if you want to persist it and your file path relies on it, then you clearly should set it. The File objects only purpose and reason that it features certain things is that it might need them for generation pathes or doing certain operations in processors.

The File object is like a DTO between persistence that the user has to take core of in his app and the library that only knows about what the file object provides.

public $fields = [
'id' => ['type' => 'uuid', 'null' => true, 'default' => null, 'length' => 36],
'user_id' => ['type' => 'string', 'null' => true, 'default' => null, 'length' => 36],
'foreign_key' => ['type' => 'string', 'null' => true, 'default' => null, 'length' => 36],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to add another fixture for AIIDs.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@dereuromark
Copy link
Collaborator Author

Closing in favor of #219

@dereuromark dereuromark deleted the 4.0-metadata branch October 15, 2022 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants