Conversation
dleard
left a comment
There was a problem hiding this comment.
This looks great! I just added a small comment on naming conventions when deciding what to name your database tables.
| -- requires: todoAppschema | ||
|
|
||
| BEGIN; | ||
| CREATE TABLE todo_app.todo_create_table ( |
There was a problem hiding this comment.
a small nitpick on table naming convention:
"todo_create_table" is kind of a confusing name for this table. A table name should describe the data that it contains.
The "thing" that this table contains is a "todo", so I would just name this table "todo"
There was a problem hiding this comment.
a small nitpick on table naming convention: "todo_create_table" is kind of a confusing name for this table. A table name should describe the data that it contains. The "thing" that this table contains is a "todo", so I would just name this table "todo"
it makes sense. deal !!
By the way, I had thought something like:
todo = what is this table for.
behavior = create , alter or remove.
table = schema table.
There was a problem hiding this comment.
Your way makes more sense due to sqitch
has desc on plan through flag -n
Step one was completely done according to instructions on readme .
Do not forget to change sqitch.conf db addr to localhost or whenever your
db is running.