Skip to content

remove-old-kcompose-files#37

Merged
mikevespi merged 1 commit intodevelopfrom
36-need-to-remove-the-kompose-files-dir
Aug 30, 2023
Merged

remove-old-kcompose-files#37
mikevespi merged 1 commit intodevelopfrom
36-need-to-remove-the-kompose-files-dir

Conversation

@YaokunLin
Copy link
Contributor

No description provided.

@YaokunLin YaokunLin linked an issue Aug 30, 2023 that may be closed by this pull request
Copy link
Contributor

@monicakochofar monicakochofar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always nice to see dead code deleted! 😄
i would just double check maybe after credentials are working that code is able to run without these!

Copy link
Contributor

@mikevespi mikevespi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it will, and that we have adjacent work to this happening in another branch that Josh was working on here: #31

Awesome, I love an all red PR!

@mikevespi mikevespi merged commit da093a1 into develop Aug 30, 2023
@mikevespi mikevespi deleted the 36-need-to-remove-the-kompose-files-dir branch August 30, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to remove the kompose-files dir I created and no longer useful

3 participants