Conversation
…s to all repo files
.devcontainer/Dockerfile
Outdated
| # [Optional] Uncomment if you want to install more global node packages | ||
| # RUN su node -c "npm install -g <your-package-list -here>" | ||
|
|
||
| RUN git clone https://github.com/asdf-vm/asdf.git ~/.asdf --branch v0.8.1 --depth 1 |
There was a problem hiding this comment.
@kriscooke, this is per the asdf docs, but the branch name could get stagnant (and actually already is, I think; their repo has a v0.9 branch now).
There was a problem hiding this comment.
This is OK for now, but is a common issue across projects to keep in mind 🤔
There was a problem hiding this comment.
their repo has a v0.9 branch now
When tracking new version releases of things, the definitive source would be the repo's releases list.
So if they have a v0.9 branch now, this would be where they're actively working on the next version. But it's not officially released (ie: ready to use) until that branch is merged to main with a git tag (version number) which will cause it to appear on the list of releases.
.devcontainer/Dockerfile
Outdated
| # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.192.0/containers/typescript-node/.devcontainer/base.Dockerfile | ||
|
|
||
| # [Choice] Node.js version: 16, 14, 12 | ||
| ARG VARIANT="16-buster" |
There was a problem hiding this comment.
We should stick to LTS Node (14)?
|
|
||
| "postCreateCommand": "yarn --dev", | ||
|
|
||
| "extensions": ["dbaeumer.vscode-eslint"] |
There was a problem hiding this comment.
This is admittedly silly and picky, but I'm a little surprised the formatter didn't remove extra blank lines in this file? 🤔
There was a problem hiding this comment.
The formatter isn't added yet--that's in PR #346
There was a problem hiding this comment.
Ah, I see - I keep getting confused by the developer experience, which is a bit self-referential. 💫
You're working on this PR while connecting to the remote contianer itself - so formatter didn't run, because the pre-commit hook isn't running yet, etc...
.devcontainer/Dockerfile
Outdated
| # RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}" | ||
|
|
||
| # [Optional] Uncomment if you want to install more global node packages | ||
| # RUN su node -c "npm install -g <your-package-list -here>" |
There was a problem hiding this comment.
I think we can probably remove the commented blocks above, since we won't be needing that functionality
2 participants
Fixes # n/a (new feature)
Proposed Changes
Create a codespace for the toolkit. This PR includes:
.devcontainerfile with the boilerplate for typescript-node containerasdfand using it to install appropriate tool versionsYou can check that the versions are correct by running
<tool> --versionin the codespaces terminal.You can check that the app starts up by running the following in the codespaces terminal:
yarn llinkyarn buildyarn storybook:bcgovoryarn storybook:button