REAMDE: update #65
Merged
REAMDE: update #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
approved these changes
Apr 23, 2025
lukevalenta
reviewed
Apr 23, 2025
| public_key_hash 20b57b9c55dab26db14fb6cc801b7d7294cbf448abb1196e1ffc19d73013498a | ||
| dns [example.com] | ||
| ip4 [198.51.100.60] | ||
| evidence-list (0 entries) |
Collaborator
There was a problem hiding this comment.
We should add a tab here, maybe, so that (0 entries) is at the same level of indentation as the values above.
Collaborator
There was a problem hiding this comment.
^clarified the comment
lukevalenta
approved these changes
Apr 23, 2025
Collaborator
lukevalenta
left a comment
lukevalenta
left a comment
There was a problem hiding this comment.
Looks good, aside from the demo updates after #66.
bwesterb
added a commit
that referenced
this pull request
Apr 23, 2025
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.